Kevin-Li-2025 commented on PR #23226: URL: https://github.com/apache/datafusion/pull/23226#issuecomment-4902376321
Thanks, good catch. I pushed a follow-up fix in . What changed: - now percent-encodes partition values when constructing object-store listing prefixes, so a SQL-visible decoded value like maps back to the path segment instead of listing . - The encoding covers path-segment-breaking characters such as , spaces, , , and . - I also converted the encoded parse-path assertions into a small table as suggested. Local checks run: - - running 1 test test helpers::tests::test_parse_partitions_for_path ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 17 filtered out; finished in 0.00s - running 1 test test helpers::tests::test_evaluate_partition_prefix ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 17 filtered out; finished in 0.01s - running 18 tests test helpers::tests::test_try_into_partitioned_file_partial_partition_skipped ... ok test helpers::tests::test_evaluate_date_partition_prefix ... ok test helpers::tests::test_try_into_partitioned_file_root_file_skipped ... ok test helpers::tests::test_parse_partitions_for_path ... ok test helpers::tests::test_evaluate_partition_prefix ... ok test helpers::tests::test_try_into_partitioned_file_wrong_partition_name ... ok test helpers::tests::test_split_files ... ok test table::tests::test_derive_common_ordering_all_none ... ok test table::tests::test_derive_common_ordering_empty_groups ... ok test helpers::tests::test_try_into_partitioned_file_decodes_partition_value ... ok test helpers::tests::test_try_into_partitioned_file_multiple_partitions ... ok test helpers::tests::test_try_into_partitioned_file_valid_partition ... ok test table::tests::test_derive_common_ordering_mixed_with_none ... ok test table::tests::test_derive_common_ordering_no_common_prefix ... ok test table::tests::test_derive_common_ordering_single_file ... ok test table::tests::test_derive_common_ordering_common_prefix ... ok test table::tests::test_derive_common_ordering_all_files_same_ordering ... ok test helpers::tests::test_expr_applicable_for_cols ... ok test result: ok. 18 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s running 7 tests test datafusion/catalog-listing/src/table.rs - table::ListingTable (line 140) - compile ... ok test datafusion/catalog-listing/src/options.rs - options::ListingOptions::with_file_extension_opt (line 137) ... ok test datafusion/catalog-listing/src/options.rs - options::ListingOptions::with_file_extension (line 117) ... ok test datafusion/catalog-listing/src/options.rs - options::ListingOptions::with_table_partition_cols (line 209) ... ok test datafusion/catalog-listing/src/options.rs - options::ListingOptions::with_file_sort_order (line 240) ... ok test datafusion/catalog-listing/src/config.rs - config::ListingTableConfig::with_listing_options (line 148) ... ok test datafusion/catalog-listing/src/config.rs - config::ListingTableConfig::with_schema (line 108) ... ok test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s all doctests ran in 5.04s; merged doctests compilation took 2.93s - New CI has started on the updated head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
