alamb commented on PR #23324:
URL: https://github.com/apache/datafusion/pull/23324#issuecomment-4903437641
> What do you think about this idea @2010YOUY01 @alamb
I think it sounds good.
I think there are some other major parts too:
1. the NoGrouping (AggregateStream):
https://github.com/apache/datafusion/blob/12bd5b076584b1eeac0e5357afce8ae6d3cd72be/datafusion/physical-plan/src/aggregates/no_grouping.rs#L48-L47
2. Also the ordering (OrderedFinalAggregateStream,
OrderedPartialAggregateStream, etc)
Looking at the names of the modules, in this directory I also feel the
structure is somewhat lost
<img width="472" height="356" alt="Screenshot 2026-07-07 at 7 31 50 AM"
src="https://github.com/user-attachments/assets/86ed2890-d0f5-451b-9d9f-281ddf1fb94f";
/>
I made a PR to try and name them more consistently:
- https://github.com/apache/datafusion/pull/23372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
