2010YOUY01 commented on PR #23324: URL: https://github.com/apache/datafusion/pull/23324#issuecomment-4913207434
> Some thoughts about later refactoring: > > * maybe we should not only maintain the agg hashtable in such approach: > > ``` > hashtable > - common > - final > - partial > ``` > > * but also maintain all the agg context following this, the re-originized code structure may be like: > > ``` > grouped_hash > - common (place the common contexts like generic hashtable `AggregateHashTable<T>`) > - final (all contexts about final) > * final hashtable > * final agg stream > * optimizations about final > - partial(all contexts about final) > * partial hashtable > * partial agg stream > * partial skip hashtable > * skip_partial.rs > * other optimizations about partial > ``` > > What do you think about this idea @2010YOUY01 @alamb Yes, I agree. I'll try to address them later. I think the logical code structure is mostly good now (how we model concepts as structs and methods). However, the physical code organization (how those structs are placed across files and folders), is still a bit messy, and we are also missing a good top-level comment that explains the overall story. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
