alamb opened a new pull request, #23373: URL: https://github.com/apache/datafusion/pull/23373
## Which issue does this PR close? - related to https://github.com/apache/datafusion/issues/23307 ## Rationale for this change The integer `IN` list sqllogictest coverage exercises literal lists, filtered column paths, NULL-containing lists, and lists that include column references. Float `IN` list evaluation now has optimized paths as well, including Float16, so the same behavior should be covered for Float16, Float32, and Float64. ## What changes are included in this PR? This adds sqllogictest coverage for Float16, Float32, and Float64 `IN` list predicates in `expr.slt`, mirroring the existing integer `IN` list coverage shape: - matching and non-matching literal lists - lists containing NULL values - `IN` lists used directly as filters - literal `IN` lists that include a column expression - self-referential column `IN` lists ## Are these changes tested? Yes. I ran: ```bash cargo test -p datafusion-sqllogictest --test sqllogictests -- expr.slt:1334 ``` I also ran the broader `expr` filter. It reached this file but failed on the pre-existing `SELECT c8/nullif(c7, 0) FROM aggregate_test_100_by_sql LIMIT 9 OFFSET 81;` expectation at `expr.slt:1938`, outside this change. ## Are there any user-facing changes? No. This only adds test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
