github-actions[bot] commented on PR #23260: URL: https://github.com/apache/datafusion/pull/23260#issuecomment-4921191215
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v54.0.0 (current) Built [ 25.372s] (current) Parsing datafusion-expr v54.0.0 (current) Parsed [ 0.070s] (current) Building datafusion-expr v54.0.0 (baseline) Built [ 25.592s] (baseline) Parsing datafusion-expr v54.0.0 (baseline) Parsed [ 0.070s] (baseline) Checking datafusion-expr v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 1.578s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/inherent_method_missing.ron Failed in: ScalarUDF::is_strict, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/633fa6b836a4ab2edb8c5635672d0742ae0bfeb8/datafusion/expr/src/udf.rs:216 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_missing.ron Failed in: method is_strict of trait ScalarUDFImpl, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/633fa6b836a4ab2edb8c5635672d0742ae0bfeb8/datafusion/expr/src/udf.rs:714 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 55.205s] datafusion-expr Building datafusion-sql v54.0.0 (current) Built [ 40.123s] (current) Parsing datafusion-sql v54.0.0 (current) Parsed [ 0.030s] (current) Building datafusion-sql v54.0.0 (baseline) Built [ 39.839s] (baseline) Parsing datafusion-sql v54.0.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-sql v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.258s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 81.651s] datafusion-sql ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
