zhuqi-lucas commented on PR #23128: URL: https://github.com/apache/datafusion/pull/23128#issuecomment-4921623206
Thanks @alamb — I agree, this is a better direction than adding a native `GroupColumn` per nested type. A single generic column backed by arrow's row format (a one-field `RowConverter`) would keep `GroupValuesColumn` usable for any row-encodable nested type, confining the row encoding to just the columns that lack a native builder instead of dropping the whole key onto `GroupValuesRows` — and could eventually let us retire `GroupValuesRows` altogether. Let me give this approach a try. Opened #23404 to track it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
