rluvaton commented on PR #23407: URL: https://github.com/apache/datafusion/pull/23407#issuecomment-4925833200
> --- failure auto_trait_impl_removed: auto trait no longer implemented --- > > Description: > A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. > ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits > impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/auto_trait_impl_removed.ron > > Failed in: > type RecordBatchStreamAdapter is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/stream.rs:406 > type RecordBatchStreamAdapter is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/stream.rs:406 > > Summary semver requires new major version: 1 major and 0 minor checks failed > Finished [ 100.350s] datafusion-physical-plan Damn I would never have caught that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
