rluvaton commented on code in PR #23407:
URL: https://github.com/apache/datafusion/pull/23407#discussion_r3553840723
##########
datafusion/physical-plan/src/sorts/streaming_merge.rs:
##########
@@ -46,15 +46,16 @@ macro_rules! merge_helper {
($t:ty, $sort:ident, $streams:ident, $schema:ident,
$tracking_metrics:ident, $batch_size:ident, $fetch:ident, $reservation:ident,
$enable_round_robin_tie_breaker:ident) => {{
let streams =
FieldCursorStream::<$t>::new($sort, $streams,
$reservation.new_empty());
- return Ok(Box::pin(SortPreservingMergeStream::new(
+ return Ok(SortPreservingMergeStream::new(
Review Comment:
> Since `SortPreservingMergeStream` is no longer has a `Stream`
implementation and you need to turn it into a stream, we might want to give it
a different name.
>
> Would it be possible to return the `impl Stream` directly from `new` to
avoid the somewhat odd construct?
I wanted to reduce the amount of changes in this PR as possible so it will
be easier to review and see the actual difference between generators and
current implementation.
this can be a followup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
