alamb commented on PR #23211: URL: https://github.com/apache/datafusion/pull/23211#issuecomment-4925931678
> > maybe we need to increase the size of the benchmark or it is very sensitive to the allocation ordering (we have seen that in other benchmarks) > > Could you provide me some pointers to the similar changes you're referring to? It's not entirely clear to me what I should be looking out for. I was thinking of some of the bitmap benchmarks we ran in arrow-rs where the state of the allocator (allocation order) mattered -- so that when run in isolation the tests didn't change but when run as the full suite the tests got slower In this case let's go with your measurements - I think we have done enough work on this PR. If we want to try and figure out the root cause of the benchmark differences, we can do so to, but I think this is fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
