Rich-T-kid commented on PR #23187: URL: https://github.com/apache/datafusion/pull/23187#issuecomment-4926823360
> Kind of annoying that make_group_column takes a field instead of a DataType. Maybe we can change that in a follow up PR? @jayshrivastava `make_group_column()` needs to take in a field because primitives can optimize storage if they know for certain no nulls will exist in the input. `primitive.rs` says : > /// Optimized to skip null buffer construction if the input is known to be non nullable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
