jayshrivastava commented on PR #23187: URL: https://github.com/apache/datafusion/pull/23187#issuecomment-4928790590
@Rich-T-kid Also, if there is already a null value in the values array, then we don't need to append a sentinel. Avoiding concat if there's no null keys or if there's already a null value might be good enough. It could avoid concating more than the pointer check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
