jayshrivastava opened a new pull request, #23423: URL: https://github.com/apache/datafusion/pull/23423
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## Rationale for this change See https://github.com/apache/datafusion/issues/22418. After migrating `DynamicFilterPhysicalExpr` serialization from relying on leaking public internals, we can now remove these unstable methods because they aren't used outside the package. ``` pub struct Inner { ... } /// Return the filter's original children (before any remapping). /// /// **Warning:** intended only for `datafusion-proto` (de)serialization. /// Not a stable API. pub fn original_children(&self) -> &[Arc<dyn PhysicalExpr>] { &self.children } /// Return the filter's remapped children, if any have been set via /// [`PhysicalExpr::with_new_children`]. /// /// **Warning:** intended only for `datafusion-proto` (de)serialization. /// Not a stable API. pub fn remapped_children(&self) -> Option<&[Arc<dyn PhysicalExpr>]> { self.remapped_children.as_deref() } ``` ## What changes are included in this PR? See above. ## Are these changes tested? - Existing unit tests are migrated to private accessors - There's no usage of these methods out side of `datafusion/physical-expr/src/expressions/dynamic_filters` ## Are there any user-facing changes? Unstable public methods and public types for `DynamicFilterPhysicalExpr` are private now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
