jayshrivastava commented on PR #23423:
URL: https://github.com/apache/datafusion/pull/23423#issuecomment-4927081017
Note we still have public methods like this
```
/// Get the dynamic filter expression for testing purposes.
/// Returns the dynamic filter expression for this hash join, if set.
pub fn dynamic_filter_expr(&self) -> Option<&Arc<DynamicFilterPhysicalExpr>>
{}
/// Set the dynamic filter on this hash join.
///
/// Resets any internal state that depends on any existing dynamic filter.
///
/// Validates that the filter's children reference valid columns in
/// the probe (right) side's schema.
pub fn with_dynamic_filter_expr(
mut self,
filter: Arc<DynamicFilterPhysicalExpr>,
) -> Result<Self> {}
```
on dynamic filter producers like `HashJoinExec`.
Not sure if we want to commit to removing those. They might come in handy
for distributed datafusion since `apply_expressions` was reverted. I'm still
thinking about the right APIs to have in datafusion for distibuted datafusion
to access dynamic filters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
