SAY-5 opened a new pull request, #23433:
URL: https://github.com/apache/datafusion/pull/23433
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #22220.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
`array_position` accepts an optional 1-indexed `start_from` argument. When
resolving it, the code converts to a 0-indexed offset with a plain `value - 1`.
For `start_from = i64::MIN` this subtraction overflows, which panics in
debug/overflow-checked builds and wraps in release. The out-of-bounds error
path also computed `from + 1`, which overflows the same way. An invalid
`start_from` should return a normal error rather than panic.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Use `saturating_sub(1)` when converting `start_from` to a 0-indexed offset
and `saturating_add(1)` when reporting it back in the out-of-bounds error. A
saturated `i64::MIN` stays negative, so the existing `from >= 0` bounds check
now rejects it with the usual `start_from out of bounds` error instead of
overflowing.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes. Added a unit test that invokes `array_position` with `start_from =
i64::MIN` and asserts an error is returned. It panics on `main` and passes with
this change.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
`array_position(..., i64::MIN)` now returns an error instead of panicking.
No API changes.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
