jayzhan211 commented on code in PR #11845:
URL: https://github.com/apache/datafusion/pull/11845#discussion_r1709491881
##########
datafusion/functions-aggregate/Cargo.toml:
##########
@@ -44,6 +44,8 @@ arrow-schema = { workspace = true }
datafusion-common = { workspace = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
+datafusion-functions-aggregate-common = { workspace = true }
+datafusion-physical-expr = { workspace = true }
Review Comment:
I think half of them are `window` which will be moved to
`functions-window-common` in the future. Another half are `equivalence`.
However, I agree they are still unnecessary dependency for
`functions-aggregate`. 😞 I think we could iteratively move `window` and maybe
`equivalence` 🤔 out from `physical-expr` and keep most of expressions under
`datafusion/physical-expr/src/expressions/` at the end if we expect minimum
dependency for 3rd party.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
