ozankabak commented on code in PR #11845:
URL: https://github.com/apache/datafusion/pull/11845#discussion_r1709553453
##########
datafusion/functions-aggregate/Cargo.toml:
##########
@@ -44,6 +44,8 @@ arrow-schema = { workspace = true }
datafusion-common = { workspace = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
+datafusion-functions-aggregate-common = { workspace = true }
+datafusion-physical-expr = { workspace = true }
Review Comment:
We can see if `window` and/or `equivalence` staying here causes any problems
in practice. If so, I agree that they can be moved in the future. However, it
is also possible that they do not pose any challenges in practice and can stay.
We'll see soon enough 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
