andygrove opened a new pull request, #23482: URL: https://github.com/apache/datafusion/pull/23482
> This PR was created by an LLM as a draft PR. I will mark it as ready for review after human review. ## Which issue does this PR close? N/A — autonomous exploratory PR. ## Rationale for this change lcm now computes its internal GCD with the binary (Stein's) algorithm (unsigned_gcd) instead of the division-based Euclidean gcd_helper, replacing per-iteration integer division with shifts for identical results. ## What changes are included in this PR? lcm now computes its internal GCD with the binary (Stein's) algorithm (unsigned_gcd) instead of the division-based Euclidean gcd_helper, replacing per-iteration integer division with shifts for identical results. ## Are these changes tested? Correctness: unit tests + seeded differential fuzz (bit-identical Arrow output vs `main`). Benchmark (criterion): - lcm both array: 25.28% faster (base 1567271ns -> cand 1171061ns) ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
