lyne7-sc opened a new pull request, #23489:
URL: https://github.com/apache/datafusion/pull/23489
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #23081.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Following #23275, all `GroupsAccumulator` implementations now provide
`convert_to_state`.
The `supports_convert_to_state` capability flag is therefore no longer
needed.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Make `GroupsAccumulator::convert_to_state` a required trait method.
- Remove `GroupsAccumulator::supports_convert_to_state` and its
implementations.
- Remove the corresponding capability checks from hash aggregation.
- Simplify skip-partial aggregation to use the required `convert_to_state`
implementation directly.
- Add a regression test covering the partial hash aggregation skip path.
- Document the breaking trait change in the 55.0.0 upgrading guide.
- Remove `FFI_GroupsAccumulator::supports_convert_to_state`. This changes
the FFI ABI layout, so providers and consumers must be rebuilt against
DataFusion 55.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes. Added a regression test verifying that skip-partial aggregation uses
the required `convert_to_state` implementation without a capability flag.
Existing physical-plan and FFI tests continue to pass.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Yes. This is a breaking Rust API change for external `GroupsAccumulator`
implementations:
- `convert_to_state` must now be implemented.
- `supports_convert_to_state` should be removed.
The migration is documented in the 55.0.0 upgrading guide.
The `FFI_GroupsAccumulator` layout has changed. FFI providers and consumers
must be rebuilt against DataFusion 55 and must not exchange this struct with
older major versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
