github-actions[bot] commented on PR #23489: URL: https://github.com/apache/datafusion/pull/23489#issuecomment-4949697875
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 105.840s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.034s] (current) Building datafusion v54.0.0 (baseline) Built [ 102.844s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.628s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 211.026s] datafusion Building datafusion-expr-common v54.0.0 (current) Built [ 18.724s] (current) Parsing datafusion-expr-common v54.0.0 (current) Parsed [ 0.018s] (current) Building datafusion-expr-common v54.0.0 (baseline) Built [ 19.079s] (baseline) Parsing datafusion-expr-common v54.0.0 (baseline) Parsed [ 0.018s] (baseline) Checking datafusion-expr-common v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.217s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure trait_method_default_impl_removed: pub trait default method impl removed --- Description: A method's default impl in an unsealed trait has been removed, breaking trait implementations that relied on that default ref: https://doc.rust-lang.org/book/ch10-02-traits.html#default-implementations impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_default_impl_removed.ron Failed in: trait method datafusion_expr_common::groups_accumulator::GroupsAccumulator::convert_to_state in file /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/groups_accumulator.rs:232 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_missing.ron Failed in: method supports_convert_to_state of trait GroupsAccumulator, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/da6043036f7c1e9a11fb1a08008a9adb854dcfe7/datafusion/expr-common/src/groups_accumulator.rs:242 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 38.715s] datafusion-expr-common Building datafusion-ffi v54.0.0 (current) Built [ 58.386s] (current) Parsing datafusion-ffi v54.0.0 (current) Parsed [ 0.061s] (current) Building datafusion-ffi v54.0.0 (baseline) Built [ 58.041s] (baseline) Parsing datafusion-ffi v54.0.0 (baseline) Parsed [ 0.062s] (baseline) Checking datafusion-ffi v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.243s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 118.208s] datafusion-ffi Building datafusion-functions-aggregate v54.0.0 (current) Built [ 30.050s] (current) Parsing datafusion-functions-aggregate v54.0.0 (current) Parsed [ 0.045s] (current) Building datafusion-functions-aggregate v54.0.0 (baseline) Built [ 30.048s] (baseline) Parsing datafusion-functions-aggregate v54.0.0 (baseline) Parsed [ 0.046s] (baseline) Checking datafusion-functions-aggregate v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.190s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 61.366s] datafusion-functions-aggregate Building datafusion-functions-aggregate-common v54.0.0 (current) Built [ 19.987s] (current) Parsing datafusion-functions-aggregate-common v54.0.0 (current) Parsed [ 0.019s] (current) Building datafusion-functions-aggregate-common v54.0.0 (baseline) Built [ 19.961s] (baseline) Parsing datafusion-functions-aggregate-common v54.0.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-functions-aggregate-common v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.135s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 40.768s] datafusion-functions-aggregate-common Building datafusion-physical-plan v54.0.0 (current) Built [ 35.971s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.137s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 35.483s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.144s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.612s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 75.131s] datafusion-physical-plan Building datafusion-spark v54.0.0 (current) Built [ 57.141s] (current) Parsing datafusion-spark v54.0.0 (current) Parsed [ 0.060s] (current) Building datafusion-spark v54.0.0 (baseline) Built [ 57.275s] (baseline) Parsing datafusion-spark v54.0.0 (baseline) Parsed [ 0.066s] (baseline) Checking datafusion-spark v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.345s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 116.004s] datafusion-spark ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
