takaebato opened a new pull request, #2401:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2401
`Dialect::identifier_quote_style` returned the default `None` for most
dialects even when the database has a documented identifier quote character.
For example `SnowflakeDialect {}.identifier_quote_style("id")` returned
`None`, so downstream SQL generators could not tell how to quote identifiers
for these dialects.
This PR implements the method for the remaining dialects: backticks for
BigQuery, ClickHouse, Databricks, Hive and Spark, and double quotes for ANSI,
DuckDB, Redshift and Snowflake, each with a reference to the database's
documentation. `GenericDialect` intentionally keeps returning `None` since it
does not assume any specific database.
The existing unit test in `src/dialect/mod.rs` is extended to cover all
dialects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
