adriangb opened a new issue, #23519:
URL: https://github.com/apache/datafusion/issues/23519
Part of #23494.
In `datafusion-datasource-{csv,json,parquet}`. Each `DataSink` implements
`try_to_proto` + an inherent `try_from_proto`. Note: the new inherent
`try_from_proto` intentionally replaces the old
`TryFromProto<&protobuf::*Sink>` impls (a documented api-change). Blocked by
#23498.
---
Follow the pattern in #23494 (reference impl: #23495 / `ProjectionExec`;
full end-state draft: #23496). Add `try_to_proto` inside `impl ExecutionPlan
for X`, add the inherent `X::try_from_proto`, repoint the decode arm, and
**delete the old central arm in the same PR** (that is the proof the hook is
reached). Keep the wire format byte-for-byte identical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
