2010YOUY01 commented on code in PR #23336:
URL: https://github.com/apache/datafusion/pull/23336#discussion_r3568493243
##########
datafusion/core/tests/fuzz_cases/sort_fuzz.rs:
##########
@@ -40,7 +40,7 @@ use test_utils::{batches_to_vec, partitions_to_sorted_vec};
const KB: usize = 1 << 10;
#[tokio::test]
-#[cfg_attr(tarpaulin, ignore)]
+#[cfg_attr(coverage, ignore)]
Review Comment:
I think they're not needed:
https://github.com/apache/datafusion/blob/f87e8174c107f61740606fa8c38b8f446911a1e8/datafusion/core/tests/fuzz.rs#L21
Those tests are under `extended_tests` attribute, and now we run `llvm-cov`
in the regular test suite, so those slow tests won't be included.
In the future if there are other tests that are too expensive to run for
`llvm-cov`, I think we should also put them in `extended_tests` feature, then
we don't have to manage this additional `coverage` attribute to keep things
simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
