lyne7-sc opened a new pull request, #23527:
URL: https://github.com/apache/datafusion/pull/23527
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This PR follows up on #23148, which introduced strictness metadata for
scalar UDF NULL propagation and used it during outer join elimination. It marks
built-in math functions that propagate NULL inputs as strict, allowing the
optimizer to recognize more null-rejecting predicates and simplify the
corresponding outer joins.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Extend the math UDF helper macros to support the `is_strict` property.
- Mark null-propagating math scalar functions as strict.
- Add unit tests covering:
- supported math functions;
- unary and binary variants;
- every combination of NULL arguments;
- non-NULL inputs.
- Add SQL logic tests showing that strict math predicates enable outer join
elimination for:
- LEFT, RIGHT, and FULL joins;
- unary and binary functions;
- nullable arguments in either position;
- binary function arguments coming from both sides of a join.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes. Unit tests cover NULL propagation for the affected math functions, and
SLTs verify the resulting outer join simplifications.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Yes. Queries containing null-rejecting predicates over math functions may
now produce more efficient plans by simplifying eligible outer joins.
There are no public API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
