freakyzoidberg commented on code in PR #23337:
URL: https://github.com/apache/datafusion/pull/23337#discussion_r3571333815
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -323,11 +325,26 @@ impl<'a> ArrayWrapper<'a> {
}
}
+/// Evaluate `array_has` with an array (per-row) needle.
Review Comment:
Agreed, it's basically an array_has kernel, and this file already carries
similar hand-rolled kernels, so this stays consistent with what's here.
If there's appetite to upstream a general array-contains kernel to arrow-rs
down the line I'd be happy to help, but that feels like a separate effort.
Appreciate the careful read and broad udnerstanding here ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]