Rich-T-kid commented on code in PR #23483:
URL: https://github.com/apache/datafusion/pull/23483#discussion_r3580231991
##########
datafusion/sqllogictest/test_files/dictionary.slt:
##########
@@ -632,4 +632,61 @@ south 2
statement ok
DROP TABLE dict_count_distinct;
+# overlapping values with different key assignments across batches
+query TI rowsort
+WITH
+ first_batch AS (
+ SELECT arrow_cast(column1, 'Dictionary(Int32, Utf8)') AS region
+ FROM (VALUES ('west'), ('east'), ('west'), (NULL)) AS t(column1)
+ ),
+ second_batch AS (
+ SELECT arrow_cast(column1, 'Dictionary(Int16, LargeUtf8)') AS region
Review Comment:
🤔 I didn't consider that datafusion would cast them before reaching the
aggregation stage. Ive updated the test to use the same key/value types while
varying the order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
