samuelcolvin opened a new pull request, #11896:
URL: https://github.com/apache/datafusion/pull/11896

   This is mostly working and `(a, b) in (('x', 'y'))` is working correctly, 
however if you have more than one value in the lookup, e.g. `('x', 'y') IN 
(('x', 'y'), ('y', 'x'))` an error occurs:
   
   ```
   External error: query failed: DataFusion error: Arrow error: Invalid 
argument error: Nested comparison: Struct([Field { name: "c0", data_type: Utf8, 
nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }, Field { 
name: "c1", data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: 
false, metadata: {} }]) == Struct([Field { name: "c0", data_type: Utf8, 
nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }, Field { 
name: "c1", data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: 
false, metadata: {} }]) (hint: use make_comparator instead)
   [SQL] select ('x', 'y') IN (('x', 'y'), ('y', 'x'));
   at test_files/struct.slt:256
   ```
   
   There are two tests that should fail.
   
   I'm not sure where to go from here?
   
   ## Which issue does this PR close?
   
   Closes #6635, continues from #8590.
   
   ## Rationale for this change
   
   See #6635 — I want to be able to use tuples as per that issue
   
   ## What changes are included in this PR?
   
   * Add tuples planning
   * add tuple coercion
   * tests
   
   ## Are these changes tested?
   
   yes.
   
   ## Are there any user-facing changes?
   
   More SQL supported.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to