jayzhan211 commented on code in PR #11896:
URL: https://github.com/apache/datafusion/pull/11896#discussion_r1712436290
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -780,6 +781,31 @@ fn coerce_numeric_type_to_decimal256(numeric_type:
&DataType) -> Option<DataType
}
}
+fn struct_coercion(lhs_type: &DataType, rhs_type: &DataType) ->
Option<DataType> {
+ use arrow::datatypes::DataType::*;
+ match (lhs_type, rhs_type) {
+ (Struct(lhs_fields), Struct(rhs_fields)) => {
+ if lhs_fields.len() != rhs_fields.len() {
+ return None;
+ }
+
+ let types = std::iter::zip(lhs_fields.iter(), rhs_fields.iter())
+ .map(|(lhs, rhs)| comparison_coercion(lhs.data_type(),
rhs.data_type()))
+ .collect::<Option<Vec<DataType>>>()?;
+
+ let fields = types
+ .into_iter()
+ .enumerate()
+ .map(|(i, datatype)| {
+ Arc::new(Field::new(format!("c{i}"), datatype, true))
Review Comment:
I think we should preserve field name and nullable, only type is updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
