mbutrovich commented on PR #4927: URL: https://github.com/apache/datafusion-comet/pull/4927#issuecomment-4985854142
The PR description reports `to_json: 9.92% faster` from a criterion `to_json` bench, but no such benchmark exists in the tree and the PR adds none. `native/spark-expr/benches/` has 20 benches and not one covers `to_json` or `struct_to_json`, and `gh pr view 4927 --json files` lists only `native/spark-expr/src/json_funcs/to_json.rs`. There is nothing to reproduce the number and nothing to gate against a future regression. - Evidence: PR file list is a single source file; `grep -rln "to_json" native/spark-expr/benches/` returns nothing. - Suggested change: add `native/spark-expr/benches/to_json.rs` (wired via a `[[bench]]` entry in `spark-expr/Cargo.toml`) that builds a `StructArray` with a mix of the shapes that exercise each `FieldStyle` (Utf8 needing escaping, Int/Bool/Decimal/Timestamp Raw, Float64 with a `NaN`/`Infinity` row, a nested struct, an all-null row, and `ignore_null_fields` both true and false), then run it before and after to confirm the delta and lock in the gate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
