andygrove commented on PR #23643: URL: https://github.com/apache/datafusion/pull/23643#issuecomment-4993805179
The semver check is reporting `constructible_struct_adds_field` for the new `partitions` field on `EmptyExecNode` and `PlaceholderRowExecNode`: > A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. This is a real, though unavoidable, break: the finding is inherent to adding a field to a prost-generated message, and the field is what fixes the bug. It only affects downstream code that constructs these two structs with an *exhaustive* struct literal; anyone using `..Default::default()` is unaffected, and the protobuf wire format itself stays compatible in both directions. Marking these `#[non_exhaustive]` to prevent a recurrence isn't an option, since `datafusion-proto` constructs them from outside the defining crate and would itself stop compiling. Per the [API health policy](https://github.com/apache/datafusion/blob/main/docs/source/contributor-guide/api-health.md), I've addressed it by: - adding the `api change` label, and - documenting the change and migration in the 55.0.0 upgrade guide (786aad4). Happy to reconsider if reviewers would rather see this deferred to a different release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
