adriangb commented on code in PR #23643:
URL: https://github.com/apache/datafusion/pull/23643#discussion_r3597045558


##########
datafusion/physical-plan/src/empty.rs:
##########
@@ -67,6 +67,11 @@ impl EmptyExec {
         self
     }
 
+    /// Number of partitions this plan produces

Review Comment:
   Can we add a note that this method is being made public only for our proto 
serialization and we don't guarantee any sort of API stability, etc? I know 
it's improper, we can always decide later to respect public API contracts for 
this method. But I think it's best to do what we can to err on the side of 
caution now because we'll probably be removing it again soon.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to