alamb commented on code in PR #23522:
URL: https://github.com/apache/datafusion/pull/23522#discussion_r3597900168
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -164,10 +164,40 @@ type InputPartitionsToCurrentPartitionReceiver =
Vec<DistributionReceiver<MaybeB
struct OutputChannel {
sender: DistributionSender<MaybeBatch>,
reservation: SharedMemoryReservation,
- spill_writer: SpillPoolWriter,
+ spill_writer: SpillPoolSink,
shared_coalescer: Option<SharedCoalescer>,
}
+/// The set of spill-pool writers for a single output partition, before they
are handed to the
+/// per-input tasks. The variant encodes the repartition mode so the wrong
writer topology cannot
+/// be constructed for a given mode.
+enum PartitionSpillWriters {
Review Comment:
this is much clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
