avantgardnerio commented on code in PR #2045:
URL:
https://github.com/apache/datafusion-ballista/pull/2045#discussion_r3598371434
##########
ballista/core/proto/ballista.proto:
##########
@@ -437,13 +442,16 @@ message ExecutorOperatingSystemSpecification {
uint64 open_files_limit = 9;
}
-message AvailableTaskSlots {
+// One instance per executor. Tracks free vcores for scheduler-side task
+// binding. See ExecutorResource for the vcore definition (YARN vcores or
+// Spark's spark.executor.cores).
+message AvailableVcores {
Review Comment:
Thanks for flagging — I looked into this and I think binary wire
compatibility is actually preserved (numbers are preserved, names shouldn't go
over the wire, IIUC). I'm scanning for other places where the PR could have
made breaking changes and will address them one by one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
