KonaeAkira commented on code in PR #23648:
URL: https://github.com/apache/datafusion/pull/23648#discussion_r3598984214
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -1067,6 +1072,20 @@ fn make_group_column(field: &Field) -> Result<Box<dyn
GroupColumn>> {
v.push(Box::new(BooleanGroupValueBuilder::<false>::new()));
}
}
+ DataType::List(child_field) => {
+ let child = make_group_column(child_field.as_ref())?;
+ v.push(Box::new(list::ListGroupValueBuilder::<i32>::new(
+ Arc::clone(child_field),
+ child,
+ )));
+ }
Review Comment:
I'm not sure about using `ListGroupValueBuilder::<i32>`. What happens when
the concatenated length of all the children exceeds `i32::MAX`? I think
`ListGroupValueBuilder` should drop the `O: OffsetSizeTrait` generic and always
use `usize` to store its offsets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
