mzabaluev commented on code in PR #23648:
URL: https://github.com/apache/datafusion/pull/23648#discussion_r3599338099
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -1067,6 +1072,20 @@ fn make_group_column(field: &Field) -> Result<Box<dyn
GroupColumn>> {
v.push(Box::new(BooleanGroupValueBuilder::<false>::new()));
}
}
+ DataType::List(child_field) => {
+ let child = make_group_column(child_field.as_ref())?;
+ v.push(Box::new(list::ListGroupValueBuilder::<i32>::new(
+ Arc::clone(child_field),
+ child,
+ )));
+ }
Review Comment:
As I understand it, the `build`/`take_n` of this builder must produce a
`ListArray`, with `i32` offsets. So an overflow would result in an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
