mkleen commented on code in PR #23605:
URL: https://github.com/apache/datafusion/pull/23605#discussion_r3600798166


##########
datafusion/physical-plan/src/joins/cross_join.rs:
##########
@@ -186,8 +186,32 @@ impl CrossJoinExec {
     /// operators on the join's children. Check 
[`super::HashJoinExec::swap_inputs`]
     /// for more details.
     pub fn swap_inputs(&self) -> Result<Arc<dyn ExecutionPlan>> {
-        let new_join =
-            CrossJoinExec::new(Arc::clone(&self.right), 
Arc::clone(&self.left));
+        // Rebuild schema with columns from right to left, preserve existing 
metadata

Review Comment:
   Yes!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to