Jefffrey opened a new pull request, #23659:
URL: https://github.com/apache/datafusion/pull/23659

   on my M4 Macbook pro, it estimates it would take 50 minutes (!) to run the 
benchmark
   
   ```sh
   datafusion (main)$ cargo bench -p datafusion --bench sql_planner_extended 
logical_plan
      Compiling datafusion-common v54.0.0 
(/Users/jeffrey/Code/datafusion/datafusion/common)
   ...
      Compiling datafusion v54.0.0 
(/Users/jeffrey/Code/datafusion/datafusion/core)
       Finished `bench` profile [optimized] target(s) in 8m 11s
        Running benches/sql_planner_extended.rs 
(/Users/jeffrey/.cargo_target_cache/release/deps/sql_planner_extended-c026520b80bba716)
   Gnuplot not found, using plotters backend
   Benchmarking logical_plan_optimize: Warming up for 3.0000 s
   Warning: Unable to complete 100 samples in 5.0s. You may wish to increase 
target time to 3077.4s, or reduce sample count to 10.
   Benchmarking logical_plan_optimize: Collecting 100 samples in estimated 
3077.4 s (100 iterations)
   ```
   
   and running it via the bot just times out: 
https://github.com/apache/datafusion/pull/23215#issuecomment-4995729774
   
   so might actually be useful to reduce the sample size so it can actually run 
and be of use to us


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to