U0001F3A2 commented on PR #23669: URL: https://github.com/apache/datafusion/pull/23669#issuecomment-5009388642
Hi @alamb, looks like #23641 landed first and closes the same issue (#23640). The `common.rs` fix here is now redundant (functionally identical to what merged), so this PR isnt really a bug fix anymore. Two things here arent covered by #23641 though: - Rust unit tests for the NULL cases. One of them, `test_to_date_null_format_slot_retaining_bytes`, builds an array whose NULL format slot still physically holds parseable bytes, so a missing validity check surfaces as a wrong value rather than an error. #23641 added only SLTs, so that path isnt guarded. - Doc updates for `to_date` / `to_timestamp*` / `to_unixtime` noting that NULL formats are skipped and an all-NULL format list yields NULL. Happy to rebase and trim this down to just the tests + docs as a follow-up to #23641, or close it if youd rather not carry them. Which do you prefer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
