xudong963 opened a new pull request, #23706:
URL: https://github.com/apache/datafusion/pull/23706

   ## Which issue does this PR close?
   
   - Closes #23705.
   
   ## Rationale for this change
   
   Arrow arrays containing no null values commonly omit the null bitmap. The 
whole-partition evaluation path for `LEAD` and `LAG` with `IGNORE NULLS` 
unconditionally unwrapped that optional bitmap, causing a panic for valid 
non-null input arrays.
   
   ## What changes are included in this PR?
   
   - Fall back to the existing regular shift implementation when the input has 
no null bitmap.
   - Add a regression test covering both `LEAD` and `LAG` with an array that 
explicitly has no null bitmap.
   
   ## Are these changes tested?
   
   Yes. The following checks pass locally:
   
   - `cargo test -p datafusion-functions-window 
test_ignore_nulls_without_null_bitmap`
   - `cargo clippy --all-targets --all-features -- -D warnings`
   - `./dev/rust_lint.sh`
   
   ## Are there any user-facing changes?
   
   `LEAD` and `LAG` with `IGNORE NULLS` no longer panic when the input Arrow 
array has no null bitmap. There are no public API changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to