gabotechs commented on issue #11680: URL: https://github.com/apache/datafusion/issues/11680#issuecomment-5021856018
🤔 Interesting, I'd have expected that maintaining an extra `Uint64Array` column would be pretty much 0 cost, as creating it costs compute that we anyways needed to do one way or another. For the clickbench results in both PRs (https://github.com/apache/datafusion/pull/23720#issuecomment-5021747597 and https://github.com/apache/datafusion/pull/23446#issuecomment-4950574858), I see the gains and regressions are so subtle and inconsistent that I could believe everything there is within noise. ClickBench q4 seems to be consistent in regressing, I'll pass that through a profiler and see if there's something obvious going on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
