edmondop commented on issue #11618: URL: https://github.com/apache/datafusion/issues/11618#issuecomment-2278917105
> IMO we should improve on signature instead of adding check in different function. This not only add unnecessary overhead and let the code less readable. And ideally we don't need any check in `return_type` and `invoke` Wouldn't inevitably be necessary if you do pattern matching to handle the branches that are impossible? (Because of signature enforcement) Only if we use refined types it would be possible to avoid I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
