Dandandan commented on PR #23720: URL: https://github.com/apache/datafusion/pull/23720#issuecomment-5025246400
> Yeah, I can imagine how you'd want to enable this based on the hashing expressions. For example, maybe hashing on a simple `int` column is not worth it, but it is in a `list<string>`. > > I still want to see if we can reach a situation where this enabled 100% of the times is worth it, that would simplify things a bit. I think for primitives I found it can be a quite slower to store the hash rather than regenerate it inside a loop as hashing is just is a shift / multiply / xor (potentially SIMD) vs a potential cache miss / extra cache usage. For (long) strings it can of course be very beneficial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
