Rachelint commented on PR #23720: URL: https://github.com/apache/datafusion/pull/23720#issuecomment-5028928056
> I think for primitives I found it can be a quite slower to store the hash rather than regenerate it inside a loop as hashing is just is a shift / multiply / xor (potentially SIMD) vs a potential cache miss / extra cache usage. Agree, what is worse: the internal hash column will be repartitioned and coalesced together with other normal columns, and `Uint64Array` is actually not small. > run benchmarks clickbench_partitioned Seems strange that q33 and q34 not get improvement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
