gmhelmold commented on PR #23484: URL: https://github.com/apache/datafusion/pull/23484#issuecomment-5025416398
Thanks for the careful review, and fair point on the comments 🙏 You're right that phrasing like "Kept as a unit test: …" only carries meaning with the context you and I have — a future reader doesn't have it. Stripped those and let the code speak. In `82a68b9`: - Removed the PR-specific comments on both unit tests. - Restructured the sort-options test to a single split point with only the `descending` flag flipped, as you suggested — it's self-explanatory now, and still fails if the sort-options check is removed. - Tightened the TEST 22 / TEST 25 descriptions to your wording. I'll keep comments lean and reader-focused going forward — thanks for pushing on clarity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
