gmhelmold commented on PR #23484: URL: https://github.com/apache/datafusion/pull/23484#issuecomment-5015899454
Good catch that this deserves clarifying 👍 I tried the metadata-only change first, but a descending Range requires descending-ordered split points — `[10, 20, 30]` with `descending: true` fails constructor validation: ``` Range partitioning split points must be strictly ordered: split point 0 ((10)) must be less than split point 1 ((20)) ``` So `[30, 20, 10]` DESC isn't a second, independent flip — it's the same partition boundaries (10/20/30) as the left's `[10, 20, 30]` ASC, just encoded in the sort's order. The only real difference between the two inputs is the sort direction, which is exactly the incompatibility under test. Added a comment above the right input in 64aba77 spelling that out for the next reader. Happy to switch to a different construction if you'd prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
