mbutrovich commented on PR #4982:
URL:
https://github.com/apache/datafusion-comet/pull/4982#issuecomment-5027220187
> You've nailed down exactly the case - it is a large static filter: `WHERE
col_name in ({strs})`
I've looked at this a bit and a few problems with Iceberg serde pop out at
me for residuals: 1) dedupe doesn't really work because they all get unique
`expr_id` 2) we're serializing stuff (`query_context`) that we never use.
I can try to come up with a cleaner way to do this. I'm afraid it ended up
with an inefficient implementation when trying to POC the Iceberg scan. But we
wanted correctness first, and then once it was correct we could optimize. This
is the optimize step :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
