mbutrovich commented on code in PR #4982:
URL: https://github.com/apache/datafusion-comet/pull/4982#discussion_r3618046077
##########
spark/src/test/scala/org/apache/comet/CometFuzzIcebergSuite.scala:
##########
@@ -118,109 +120,56 @@ class CometFuzzIcebergSuite extends CometFuzzIcebergBase
{
}
}
- test("decode") {
+ test("filter pushdown - fuzz predicates over primitive columns") {
val df = spark.table(icebergTableName)
- // We want to make sure that the schema generator wasn't modified to
accidentally omit
- // BinaryType, since then this test would not run any queries and silently
pass.
- var testedBinary = false
- for (field <- df.schema.fields if field.dataType == BinaryType) {
- testedBinary = true
- // Intentionally use odd capitalization of 'utf-8' to test normalization.
- val sql = s"SELECT decode(${field.name}, 'utF-8') FROM $icebergTableName"
- checkSparkAnswerAndOperator(sql)
- }
- assert(testedBinary)
- }
-
- test("regexp_replace") {
Review Comment:
`decode` and `regexp_replace` are exercise elsewhere and this is is
redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
