adriangb commented on PR #23683: URL: https://github.com/apache/datafusion/pull/23683#issuecomment-5028312873
Instead of duplicating could we move the code as you've done but then rewrite serialize_file_scan_config/parse_protobuf_file_scan_config as delegating wrappers to the new inline methods? then we don't need to test byte equality, we avoid drift, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
