saadtajwar commented on PR #23520:
URL: https://github.com/apache/datafusion/pull/23520#issuecomment-5028459063
> > Thank you @timsaucer - just updated the description regarding the API
change!
>
> Sorry, I guess I wasn't explicit enough. We are changing
>
> ```
> impl From<&FFI_Partitioning> for Partitioning {
> ```
>
> to
>
> ```
> impl TryFrom<&FFI_Partitioning> for Partitioning {
> ```
>
> That's the API change that I think needs a short description in the
upgrade guide in `docs/source/library-user-guide/upgrading/55.0.0.md`
Oh apologies, was not aware of the upgrade guide haha - thanks for taking
the time to spell this out! I know you approved earlier, but if we think this
is still needed then happy to add it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
