adriangb commented on code in PR #23708:
URL: https://github.com/apache/datafusion/pull/23708#discussion_r3618309467
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -2961,6 +2957,10 @@ pub trait PhysicalPlanNodeExt: Sized {
})
}
+ #[deprecated(
+ since = "55.0.0",
+ note = "unused by DataFusion; `FilterExec` serializes itself via
`ExecutionPlan::try_to_proto`"
+ )]
Review Comment:
Can we have the deprecated method delegate to the new one to avoid code
duplication and drift?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
