Copilot commented on code in PR #23722:
URL: https://github.com/apache/datafusion/pull/23722#discussion_r3620007885
##########
datafusion/physical-expr/src/expressions/binary/kernels.rs:
##########
@@ -25,6 +25,7 @@ use arrow::compute::kernels::bitwise::{
};
use arrow::compute::kernels::boolean::not;
use arrow::compute::kernels::comparison::{regexp_is_match,
regexp_is_match_scalar};
+use arrow::compute::kernels::take::take;
use arrow::datatypes::DataType;
Review Comment:
Prefer importing the public `arrow::compute::take` API rather than
`arrow::compute::kernels::take::take`. Other DataFusion code uses
`arrow::compute::take` (e.g. dictionary handling in
`physical-expr/src/expressions/in_list/static_filter.rs`), and depending on the
`kernels::*` module path makes this code more brittle to Arrow internal
refactors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
